Remove password protection of empty tokens#1006
Merged
Magnus-Kuhn merged 6 commits intomainfrom Mar 26, 2026
Merged
Conversation
Magnus-Kuhn
changed the title
tnotheis
previously approved these changes
Mar 24, 2026
Member
tnotheis
left a comment
tnotheis
left a comment
There was a problem hiding this comment.
LGTM. But you should wait for at least one additional review.
Magnus-Kuhn
changed the title
tnotheis
approved these changes
Mar 26, 2026
Milena-Czierlinski
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readiness checklist
Description
Since a presentation token utilizes an empty token and can't be password-protected due to it upgrading to a non-empty token, the empty token is made non-protected.